Fix invalid domain

Co-authored-by: sesn-odoo <sesn@odoo.com>

.gitignore

@@ -1,3 +1,5 @@
 __pycache__/
 out/
 .venv
+.idea/
+.vscode/

src/config.py

@@ -1,9 +1,9 @@
 import random
+from datetime import datetime
 
 vfyd_tags = [
     "vfyd accounting",
     "vfyd discuss",
-    "vfyd easy",
     "vfyd editor",
     "vfyd js",
     "vfyd marketing",
@@ -16,16 +16,29 @@ vfyd_tags = [
     "vfyd vidange",
     "vfyd website",
     "vfyd industry",
+    "vfyd voip",
+    "vfyd ai",
+    "vfyd iot",
 ]
 
-team = [
-    "nle",
+type TeamMember = str
+
+team: list[TeamMember] = [
     "abz",
     "hael",
     "roen",
     "sbel",
     "wasa",
     "huvw",
+    "artn",
+    "gvar",
+    "sben",
 ]
 
+is_friday = datetime.now().weekday() == 4
+
+if not is_friday:
+    team.append("nle")
+
+
 random.shuffle(team)

src/leave_service.py

@@ -0,0 +1,39 @@
+import odoo_client
+from datetime import datetime
+from leave import Leave
+import re
+
+
+class LeaveService:
+    def __init__(self, client: odoo_client.OdooClient):
+        self.client = client
+
+    def fetch_available_employees(self, team: list[str]) -> list:
+        today = datetime.now().strftime("%Y-%m-%d")
+        domain = [
+            ("start_datetime", "<=", today),
+            ("stop_datetime", ">=", today),
+        ]
+        domain.extend(["|"] * (len(team) - 1))
+        domain.extend(
+            [("employee_id.name", "=ilike", f"%({employee})") for employee in team]
+        )
+        leaves = self.client.web_search_read(Leave, domain)
+
+        team_availability = {employee: (True, True) for employee in team}
+
+        for leave in leaves:
+            employee = re.search(r"\((.*?)\)", leave.employee_id).group(1).lower()
+            is_morning = leave.start_datetime.hour < 11
+            is_afternoon = leave.stop_datetime.hour >= 14
+            if is_morning:
+                team_availability[employee] = (False, team_availability[employee][1])
+            if is_afternoon:
+                team_availability[employee] = (team_availability[employee][0], False)
+
+        available_employees = [
+            employee
+            for employee, (morning, afternoon) in team_availability.items()
+            if morning or afternoon
+        ]
+        return available_employees

src/main.py

@@ -1,16 +1,19 @@
 import click
 import random
 import odoo_client
-import re
 from rich import print, console
-from datetime import datetime
 from collections import defaultdict
-from config import vfyd_tags, team
+from config import vfyd_tags, team, TeamMember
+from leave_service import LeaveService
+from task_repository import TaskRepository
+from storage import JsonDispatchStorage, DispatchStorage
 from tasks import Task
-from leave import Leave
-from storage import DispatchStorage
 
 console = console.Console()
+storage: DispatchStorage = JsonDispatchStorage()
+client = odoo_client.OdooClient()
+leave_service = LeaveService(client)
+task_repository = TaskRepository(client, vfyd_tags)
 
 
 @click.group()
@@ -22,80 +25,48 @@ def cli() -> None:
 def dispatch():
     """Randomly distribute unassigned tasks among team members."""
 
-    client = odoo_client.OdooClient()
-    today = datetime.now().strftime("%Y-%m-%d")
-    domain = [
-        ("start_datetime", "<=", today),
-        ("stop_datetime", ">=", today),
-    ]
-    domain.extend(["|"] * (len(team) - 1))
-    domain.extend(
-        [("employee_id.name", "=ilike", f"%({employee})") for employee in team]
-    )
-    leaves = client.web_search_read(Leave, domain)
+    if storage.load():
+        print("[red]Tickets were already dispatched.[/red]")
+        return
 
-    team_availability = dict()
-    for employee in team:
-        team_availability[employee] = (True, True)
+    available_employees = leave_service.fetch_available_employees(team)
 
-    for leave in leaves:
-        employee = re.search(r"\((.*?)\)", leave.employee_id).group(1).lower()
-        is_morning = leave.start_datetime.hour < 11
-        is_afternoon = leave.stop_datetime.hour >= 14
-        if is_morning:
-            team_availability[employee] = (False, team_availability[employee][1])
-        if is_afternoon:
-            team_availability[employee] = (team_availability[employee][0], False)
+    if not available_employees:
+        print("[red]No available employees for dispatch.[/red]")
+        return
 
-    available_employees = [
-        employee
-        for employee, availability in team_availability.items()
-        if availability[0] or availability[1]
-    ]
-
-    previous_dispatch = DispatchStorage.load_week_to_date()
+    previous_dispatch = storage.load_week_to_date()
     previous_dispatch_ids = [
         task_id for tasks in previous_dispatch.values() for task_id in tasks
     ]
 
-    domain = [
-        ("stage_id", "=", 194),
-        ("user_ids", "=", False),
-        ("project_id", "=", 49),
-        ("tag_ids", "not in", vfyd_tags),
-        ("id", "not in", previous_dispatch_ids),
-    ]
-    records = client.web_search_read(Task, domain)
+    # Find unsorted tasks that have not been dispatched on previous days,
+    # Assign them to team members and save the result
+    new_unsorted_tasks = task_repository.get_unsorted_excluding(previous_dispatch_ids)
+    random.shuffle(new_unsorted_tasks)
+    new_dispatch: dict[TeamMember, list[int]] = defaultdict(list)
+    out: dict[TeamMember, list[Task]] = defaultdict(list)
+    for idx, task in enumerate(new_unsorted_tasks):
+        member = available_employees[idx % len(available_employees)]
+        new_dispatch[member].append(task.id)
+        out[member].append(task)
+    storage.save(new_dispatch)
 
-    random.shuffle(records)
-    dispatch = defaultdict(list)
-    out = defaultdict(list)
-    for idx, task in enumerate(records):
-        dispatch[available_employees[idx % len(available_employees)]].append(task.id)
-        out[available_employees[idx % len(available_employees)]].append(task)
-
-    DispatchStorage.save(dispatch)
-
-    domain = [
-        ("stage_id", "=", 194),
-        ("user_ids", "=", False),
-        ("project_id", "=", 49),
-        ("tag_ids", "not in", vfyd_tags),
-        ("id", "in", previous_dispatch_ids),
-    ]
-    records = client.web_search_read(Task, domain)
-
-    merged = defaultdict(list)
+    # Find unsorted tasks that have been dispatched on previous days.
+    # Add them back to the previously assign team members
+    old_unsorted_tasks = task_repository.get_unsorted_within(previous_dispatch_ids)
+    combined_tasks_to_sort: dict[TeamMember, list[Task]] = defaultdict(list)
     for member, task_ids in previous_dispatch.items():
         for task_id in task_ids:
-            task = next((t for t in records if t.id == task_id), None)
+            task = next((t for t in old_unsorted_tasks if t.id == task_id), None)
             if task:
-                merged[member].append(task)
+                combined_tasks_to_sort[member].append(task)
 
+    # Merge the new unsorted tasks with the old ones
     for member, tasks in out.items():
-        merged[member].extend(tasks)
+        combined_tasks_to_sort[member].extend(tasks)
 
-    for key, tasks in merged.items():
+    for key, tasks in combined_tasks_to_sort.items():
         print(f"**{key}:**")
         for task in tasks:
             print(task.url)
@@ -104,15 +75,7 @@ def dispatch():
 @cli.command()
 def status():
     """Show all unassigned tasks in the backlog."""
-
-    client = odoo_client.OdooClient()
-    domain = [
-        ("stage_id", "=", 194),
-        ("user_ids", "=", False),
-        ("project_id", "=", 49),
-        ("tag_ids", "not in", vfyd_tags),
-    ]
-    tasks = client.web_search_read(Task, domain)
+    tasks = task_repository.get_unassigned_tasks()
     for task in tasks:
         print(task)
 
@@ -120,17 +83,9 @@ def status():
 @cli.command()
 def check():
     """Check which previously dispatched tasks are still not completed."""
-
-    dispatch = DispatchStorage.load()
+    dispatch = storage.load()
     reverse_dispatch = {v: k for k, vs in dispatch.items() for v in vs}
-    client = odoo_client.OdooClient()
-    domain = [
-        ("id", "in", list(reverse_dispatch.keys())),
-        ("tag_ids", "not in", vfyd_tags),
-        ("stage_id", "=", 194),
-        ("project_id", "=", 49),
-    ]
-    tasks = client.web_search_read(Task, domain)
+    tasks = task_repository.get_tasks_with_ids(reverse_dispatch.keys())
 
     not_done = defaultdict(list)
     for task in tasks:

src/model.py

@@ -1,12 +1,12 @@
-from typing import Dict, Self, Any, get_origin
+from typing import Self, Any, get_origin
 from dataclasses import fields, Field
 from datetime import datetime
 
 
 class OdooModel:
     @classmethod
-    def specification(cls) -> Dict[str, Any]:
-        def field_spec(f: Field) -> Dict[str, Any]:
+    def specification(cls) -> dict[str, Any]:
+        def field_spec(f: Field) -> dict[str, Any]:
             field_type = f.type
             if f.name.endswith("_id") or f.name.endswith("_ids"):
                 return {
@@ -29,7 +29,7 @@ class OdooModel:
         return spec
 
     @classmethod
-    def from_record(cls, record: Dict) -> Self:
+    def from_record(cls, record: dict) -> Self:
         init_args = {}
         for f in fields(cls):
             if f.init and f.name in record:

src/odoo_client.py

@@ -1,7 +1,7 @@
 import os
 import requests
 import random
-from typing import Any, Dict, List, TypeVar, Type
+from typing import Any, TypeVar
 from model import OdooModel
 
 
@@ -22,10 +22,10 @@ class OdooClient:
     def rpc(
         self, model: str, method: str, *args: Any, **kwargs: Any
     ) -> requests.Response:
-        body: Dict[str, Any] = {
+        body: dict[str, Any] = {
             "jsonrpc": "2.0",
             "method": method,
-            "id": random.randint(1, 1000000),
+            "id": random.randint(1, 1_000_000),
             "params": {
                 "model": model,
                 "method": method,
@@ -34,23 +34,27 @@ class OdooClient:
             },
         }
 
-        return self.session.post(
+        response = self.session.post(
             f"{self.base_url}/web/dataset/call_kw",
             json=body,
         )
+        response.raise_for_status()
+        return response
 
     def web_search_read(
         self,
-        model: Type[T],
-        domain: List[tuple],
+        model: type[T],
+        domain: list[tuple[Any, ...]],
         *args: Any,
         **kwargs: Any,
-    ) -> List[T]:
+    ) -> list[T]:
         args = [domain, model.specification(), *args]
         res = self.rpc(model._name, "web_search_read", *args, **kwargs)
         res.raise_for_status()
         json = res.json()
-        if json.get("error"):
-            raise Exception(json.get("error"))
+
+        if error := json.get("error"):
+            raise RuntimeError(f"Odoo RPC Error: {error}")
+
         records = json.get("result", {}).get("records", [])
         return [model.from_record(record) for record in records]

src/storage.py

@@ -1,27 +1,18 @@
-from typing import Dict, List, Optional
+from typing import Optional
 from datetime import datetime, timedelta
+from pathlib import Path
 import json
+from config import TeamMember
 
 
 class DispatchStorage:
-    @classmethod
-    def path(cls, date: Optional[str] = None) -> str:
-        if date is None:
-            date = datetime.now().strftime("%Y-%m-%d")
-        return f"out/{date}_dispatch.json"
+    def load(self, date: Optional[str] = None) -> dict[TeamMember, list[int]]: ...
 
-    @classmethod
-    def load(cls, date: Optional[str] = None) -> Dict[str, List[int]]:
-        with open(cls.path(date), "r") as f:
-            return json.load(f)
+    def save(
+        self, dispatch: dict[TeamMember, list[int]], date: Optional[str] = None
+    ) -> None: ...
 
-    @classmethod
-    def save(cls, dispatch: Dict[str, List[int]], date: Optional[str] = None) -> None:
-        with open(cls.path(date), "w") as f:
-            json.dump(dispatch, f)
-
-    @classmethod
-    def load_week_to_date(cls) -> Dict[str, List[int]]:
+    def load_week_to_date(self) -> dict[TeamMember, list[int]]:
         """
         Loads and combines dispatch data from the start of the current week up to today.
         """
@@ -29,10 +20,10 @@ class DispatchStorage:
         days_since_monday = today.weekday()
         current_date = today - timedelta(days=days_since_monday)
 
-        combined_dispatch: Dict[str, List[int]] = {}
+        combined_dispatch: dict[str, list[int]] = {}
         while current_date.date() < today.date():
             date_str = current_date.strftime("%Y-%m-%d")
-            daily_dispatch = cls.load(date_str)
+            daily_dispatch = self.load(date_str)
             for key, values in daily_dispatch.items():
                 if key in combined_dispatch:
                     combined_dispatch[key].extend(values)
@@ -41,3 +32,26 @@ class DispatchStorage:
             current_date += timedelta(days=1)
 
         return combined_dispatch
+
+
+class JsonDispatchStorage(DispatchStorage):
+    @staticmethod
+    def path(date: Optional[str] = None) -> Path:
+        if date is None:
+            date = datetime.now().strftime("%Y-%m-%d")
+        return Path("out", f"{date}_dispatch.json")
+
+    def load(self, date: Optional[str] = None) -> dict[TeamMember, list[int]]:
+        try:
+            with open(self.path(date), "r") as f:
+                return json.load(f)
+        except FileNotFoundError:
+            return {}
+
+    def save(
+        self, dispatch: dict[TeamMember, list[int]], date: Optional[str] = None
+    ) -> None:
+        path = self.path(date)
+        path.parent.mkdir(exist_ok=True)
+        with open(path, "w") as f:
+            json.dump(dispatch, f)

src/task_repository.py

@@ -0,0 +1,64 @@
+from typing import Iterable
+
+from tasks import Task
+
+STAGE_BACKLOG = 194
+PROJECT_ID = 49
+
+
+class TaskRepository:
+    def __init__(self, client, vfyd_tags: Iterable[int]):
+        self.client = client
+        self._base_domain = [
+            ("stage_id", "=", STAGE_BACKLOG),
+            ("project_id", "=", PROJECT_ID),
+            ("tag_ids", "not in", list(vfyd_tags)),
+        ]
+
+    def _search(self, domain: list) -> list[Task]:
+        return self.client.web_search_read(Task, domain)
+
+    def get_unassigned_tasks(self) -> list[Task]:
+        return self._search(
+            [
+                *self._base_domain,
+                ("user_ids", "=", False),
+            ]
+        )
+
+    def get_tasks_with_ids(self, ids: Iterable[int]) -> list[Task]:
+        ids = list(ids)
+        if not ids:
+            return []
+
+        domain = [
+            *self._base_domain,
+            ("id", "in", ids),
+        ]
+        return self._search(domain)
+
+    def get_unsorted_excluding(self, exclude_ids: Iterable[int]) -> list[Task]:
+        exclude_ids = list(exclude_ids)
+
+        domain = [
+            *self._base_domain,
+            ("user_ids", "=", False),
+        ]
+
+        if exclude_ids:
+            domain.append(("id", "not in", exclude_ids))
+
+        return self._search(domain)
+
+    def get_unsorted_within(self, ids: Iterable[int]) -> list[Task]:
+        included_ids = list(ids)
+        if not included_ids:
+            return []
+
+        domain = [
+            *self._base_domain,
+            ("user_ids", "=", False),
+            ("id", "in", included_ids),
+        ]
+
+        return self._search(domain)

src/tasks.py

@@ -1,5 +1,4 @@
 from dataclasses import dataclass, field
-from typing import List
 from model import OdooModel
 
 
@@ -9,7 +8,7 @@ class Task(OdooModel):
 
     id: int
     name: str
-    tag_ids: List[str]
+    tag_ids: list[str]
     stage_id: str
     priority: bool
     url: str = field(init=False)